Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xvrtech.js.org #9393

Closed
wants to merge 1 commit into from
Closed

xvrtech.js.org #9393

wants to merge 1 commit into from

Conversation

FullStackedRVC
Copy link

@FullStackedRVC FullStackedRVC commented Nov 18, 2024 •
edited
Loading

@MattIPv4 MattIPv4 changed the title thanks xvrtech.js.org Nov 18, 2024
MattIPv4
MattIPv4 requested changes Nov 18, 2024
View reviewed changes
Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there!

❌ As noted in our README, js.org is focusing on granting subdomain requests to projects with a clear relation to the JavaScript ecosystem and community.

Projects such as personal pages, blogs, and Discord bot pages will no longer be accepted. Projects such as NPM packages, libraries, tools that have a clear direct relation to JavaScript, will be accepted when requesting a JS.ORG subdomain.

Need a subdomain for a project that doesn't fall within the criteria for JS.ORG? Take a look at https://github.com/js-org/js.org/wiki/Similar-Services

PULL_REQUEST_TEMPLATE/addExternalPage.md
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your PR should only be editing cnames_active.js

PULL_REQUEST_TEMPLATE/addGitHubPage.md
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your PR should only be editing cnames_active.js

cnames_active.js
@@ -3604,6 +3604,7 @@ var cnames_active = {
"xterminal": "henryhale.github.io/xterminal",
"xto6": "mohebifar.github.io/xto6", // noCF? (don´t add this in a new PR)
"xtype": "lucono.github.io/xtypejs", // noCF? (don´t add this in a new PR)
"xvrtech": "https://fullstackedrvc.github.io/Agency/",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"xvrtech": "https://fullstackedrvc.github.io/Agency/",
"xvrtech": "fullstackedrvc.github.io/Agency",

You do not need the https:// nor the trailing slash

@MattIPv4 MattIPv4 added invalid unrelated / unqualified the content of the page is unrelated to JS, is a personal blog or unqualified for another reason labels Nov 18, 2024
@FullStackedRVC FullStackedRVC closed this by deleting the head repository Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MattIPv4 MattIPv4 MattIPv4 requested changes

Assignees
No one assigned
Labels
invalid unrelated / unqualified the content of the page is unrelated to JS, is a personal blog or unqualified for another reason
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FullStackedRVC @MattIPv4